Add other correct test results to the test checks for divisive #7263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this approach (with the walrus) won't work for these cases because it relies on the first part of the partition to try to identify which answer is being considered. And of course, the first part of the partition doesn't determine uniquely which answer we should consider. The solution merged in #7251 is preferred for this reason. we'll find a use for walrii (is that the plural?) soon enough. :) We just need to make sure it is as readable as a version that doesn't use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests had more than opne possible answer, but only checked for the one given by this implementation. Testing on nx-parallel as mentioned in networkx/nx-parallel#36 .
This PR adds the other possible correct test results to these tests.