Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for random_clustered and update function names #7273

Merged
merged 3 commits into from Feb 14, 2024

Conversation

vanshika230
Copy link
Contributor

I have increased test coverage for random_clustered.py according to here at 93.55%:-
https://app.codecov.io/gh/networkx/networkx/blob/main/networkx%2Fgenerators%2Frandom_clustered.py
It is now at a 100% as seen below :-
image
I have also renamed functions to follow better coding practices.

vanshika230 and others added 2 commits February 6, 2024 11:20
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now, thanks @vanshika230 !

@MridulS MridulS merged commit c855557 into networkx:main Feb 14, 2024
41 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Feb 14, 2024
@vanshika230 vanshika230 deleted the random_clustered_test_cov branch February 15, 2024 06:02
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
…etworkx#7273)

* Improve test_cov for random_clustered

* Add match

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

* Cleanup invalid joint deg seq tests.

---------

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants