Review and update @nx._dispatchable usage since 3.2.1
#7302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschult
reviewed
Feb 17, 2024
networkx/utils/backends.py
Outdated
Comment on lines
809
to
810
| from numpy.random import RandomState | ||
|
|
There was a problem hiding this comment.
Should we support np.random.Generator alongside RandomState?
There was a problem hiding this comment.
Good call. Probably:
networkx/networkx/utils/misc.py
Lines 265 to 266 in d709049
The tests don't need this to pass, but I added it anyway in case future tests need it.
dschult
approved these changes
Feb 18, 2024
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* Review and update `@nx._dispatchable` usage since 3.2.1 * Also handle `np.random.Generator`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds (and updates)
@nx._dispatchabledecorator to some new functions. I reviewed the diff since version 3.2.1.There are now three algorithms I know that implicitly use
"weight"weight (noweightargument):hits,tournament_matrix, andis_regular_expander.The only other functional change I made in this PR is to add
seedtorandom_regular_expander_graph.