Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dispatching to broadcasting.py #7386

Merged
merged 1 commit into from Apr 2, 2024
Merged

Add dispatching to broadcasting.py #7386

merged 1 commit into from Apr 2, 2024

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Apr 2, 2024

I reviewed all changes since #7302 to look for updates to make for the dispatch decorator. My goal is to do this kind of check before each new release.

dschult
dschult approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- I don't have way to check for others that might have snuck in, but you've got some pretty good tools for that. :)

rossbar
rossbar approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eriknw !

@rossbar rossbar merged commit fbb2d82 into networkx:main Apr 2, 2024
41 of 42 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Apr 2, 2024
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@eriknw @cvanelteren
Add dispatching to broadcasting.py (networkx#7386)
0da6dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
type: Maintenance
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eriknw @dschult @rossbar @jarrodmillman