Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for bipartite matrix.py #7312

Merged
merged 2 commits into from Mar 4, 2024

Conversation

vanshika230
Copy link
Contributor

I have increased test coverage for matrix.py according to here at 95.12% :-
https://app.codecov.io/gh/networkx/networkx/blob/main/networkx%2Falgorithms%2Fbipartite%2Fmatrix.py
The test coverage is now at a 100% as seen below :-
after
I would love a review on this and do any changes if required!

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding the test, minor suggestion on how to improve it!

networkx/algorithms/bipartite/tests/test_matrix.py Outdated Show resolved Hide resolved
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vanshika230

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks!!

@dschult dschult merged commit df96f47 into networkx:main Mar 4, 2024
41 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Mar 4, 2024
@vanshika230 vanshika230 deleted the testcov_bipmatrix branch March 4, 2024 05:46
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* improve test coverage for matrix.py

* Update networkx/algorithms/bipartite/tests/test_matrix.py

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

---------

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants