Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the create argument of nonisomorphic_trees #7316

Merged
merged 4 commits into from Feb 28, 2024
Merged

Deprecate the create argument of nonisomorphic_trees #7316

merged 4 commits into from Feb 28, 2024

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Feb 27, 2024

Closes #7256

dschult
dschult approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
Thanks!

@MridulS MridulS merged commit 611cc9a into networkx:main Feb 28, 2024
42 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Feb 28, 2024
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@rossbar @cvanelteren
Deprecate the create argument of nonisomorphic_trees (networkx#7316)
9247e4d 
* Add deprecation warning and docstring warning.

* Add deprecated_call to tests.

* Add warnings filter to test conf.

* Add note to deprecation docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

Assignees
No one assigned
Labels
type: API
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

nonisomorphic_trees create argument
4 participants
@rossbar @dschult @jarrodmillman @MridulS