Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty GraphML attribute is not parsed #7319

Merged
merged 3 commits into from Mar 1, 2024
Merged

Conversation

salym
Copy link
Contributor

@salym salym commented Feb 29, 2024

Fixes #7291

networkx does not parse GraphML attributes that are empty.
As a result, they will not be added to the graph.
This fix will create the attribute with an empty string.

Fixes  networkx#7291

networkx does not parse GraphML attributes that are empty.
This fix will create the attribute with an empty string.
@salym salym changed the title Empty GraphML attribute is not parsed (main branche) Empty GraphML attribute is not parsed (main branch) Feb 29, 2024
@salym salym changed the title Empty GraphML attribute is not parsed (main branch) Empty GraphML attribute is not parsed Mar 1, 2024
@salym salym changed the title Empty GraphML attribute is not parsed Fix empty GraphML attribute is not parsed Mar 1, 2024
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@MridulS MridulS merged commit c339da9 into networkx:main Mar 1, 2024
43 of 44 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Mar 1, 2024
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Empty GraphML attribute is not parsed (main branche)

Fixes  networkx#7291

networkx does not parse GraphML attributes that are empty.
This fix will create the attribute with an empty string.

* added test test_graphml.py

* minor changes (lint)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Empty GraphML attribute is not shown with networkx
4 participants