Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #7320

Merged
merged 2 commits into from Mar 4, 2024
Merged

Update __init__.py #7320

merged 2 commits into from Mar 4, 2024

Conversation

BucketHeadP65
Copy link
Contributor

Missing interface in generators for harary graph.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed seem like an oversight; I suspect the hmn_harary_graph and hkn_harary_graph were indeed intended to accessible in the main namespace with the other generators. If so, then this change will do so.

I'll approve this on the assumption that these are intended to be exported - if there's some other reason that these generators were intentionally excluded from the main namespace please LMK!

@BucketHeadP65
Copy link
Contributor Author

That was exactlty the intention actually. Thank you!

@dschult
Copy link
Member

dschult commented Mar 4, 2024

Thanks!

@dschult dschult merged commit 7e97d4c into networkx:main Mar 4, 2024
43 of 44 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Mar 4, 2024
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Update __init__.py

* Update __init__.py corrected import order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants