Try/except intermittently failing basemaps in geospatial examples #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert this when contextily basemap issue is improved.
rossbar
changed the title
dschult
approved these changes
Mar 4, 2024
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…tworkx#7324) * Temporarily make poinst geospatial example non-executable. Revert this when contextily basemap issue is improved. * Revert "Temporarily rm geospatial examples to fix CI. (networkx#7299)" This reverts commit fce5d7d. * Revert "Temporarily make poinst geospatial example non-executable." This reverts commit 02927e3. * Try/except add_basemap in geospatial examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unfortunately missed one of the instances ofcontextily.add_basemapin #7299 which is also not intermittently failing on CI. This PR disablesplot_pointsin the gallery. I'll update #7301 so that it's clear that #7299 and this PR need to be reverted when the underlying contextily issue is solved.Update
I just went ahead and wrapped the instances of
contextily.add_basemapin try/excepts in all examples. That way we don't have to keep tracking CI issues.Reverts #7299 and closes #7301