make doc_string examples order-independent by removing np.set_printoptions #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Ack, nice catch @dschult - the set_printoptions should've been a red flag that I missed during review!
This LGTM - alternatively if fewer digits is really desired then np.printoptions can be used as a context manager to prevent the issues with global option setting:
>>> with np.printoptions(precision=4):
... print(nx.normalized_laplacian_matrix(DiG).toarray())
mjschwenne
approved these changes
Mar 20, 2024
|
Thanks Ross and Matt for the 2 approvals -- I'm going to merge it myself just so the cron job can test it. |
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…tions (networkx#7361) remove np.set_printoptions from normalized_laplacian_matrix doc_string example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the pytest-randomly tests in networkx/linalg which started occasionally failing due to a new doc_string test that changed the print setting for numpy arrays. The printoptions were set to print 4 digits for array values. Luckily the example still fits in the code width using the standard 8 digits.
So this fix just removes the line that sets the numpy print options and expands the example to show 8 digits.
This should go in before v3.3