New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the backend docs and connect the config docs. Both in a single sidebar entry. #7389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @dschult , LGTM! I think this captures the most important components of the backend docs reorg - exposing functionality and pulling it into it's own refguide "article". Additional updates to the content of the docs themselves can be handled in follow-up PRs!
The docs for the constant
Also, I think adding the docstring of the base |
I put the base class Config into this PR now... Thanks for pointing that out. And I agree with your other comments @Schefflera-Arboricola, but I wasn't able to get numpydoc to handle those cases nicely. I am hoping to be able to get this into release 3.3. And I don't like putting docs directly into the More details: The
What do you think of my inclusion of Config, and changing the _decorator doc to use |
Based on the review comments above and discussions at the meetings this week, I have made a few more changes:
|
Looks like the tests are failing due to chocolatey's webpage not responding. :) |
…idebar entry. (networkx#7389) * make doc sidebar entry for backends and config * put _dispatchable into section heading name for ease of doc search * add Config class to the docs * Change docs based on review comments and meeting discussions * move backend tests from classes/tests directory to utilities/test
Here's one attempt at separating the backend docs from other utilities. It also adds the config docs to the html documentation on the same page as the backend description. When other config options (non backend) get introduced we should separate the config and backend pages.
So, now in the Reference pages there is a sidebar entry called "Backends and Configs". It describes the backend system, the _dispatchable decorator, and the nx.config object.
It'd be nice to have an overview of the
nx.config
object and its purpose and how to use it. But this PR only moves what we've already got in the doc_strings into the html docs.