Fix exception for del config[key]
#7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make `cfg.__setitem__` faster
|
oops -- spoke too fast -- The code looked good, but the tests show that something is wacky... Probably a regex issue. |
|
Oh shoot. I ran the tests locally. Investigating/fixing now |
|
fixed |
rossbar
approved these changes
Apr 4, 2024
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* Fix exception for `del config[key]` Also, make `cfg.__setitem__` faster * Fix regex in test for Python 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make
cfg.__setitem__(a little) faster.I forgot to update
__delitem__when I enabledstrict=Falseoption for configs.