WIP: Support MetaModels 2.3 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MetaModels need doctrine/cache in the version ^2.1
Remove the version 1.0 'cause of API changes.
Closed
dmolineus
requested changes
Feb 20, 2023
|
Thanks @stefanheimes, next time please follow the coding standard assistance provided by the github acitons annotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dmolineus
this PR is for adding support for Contao 4.13 / PHP 8.x / MetaModels 2.3
One of the main change is the removing of the "doctrine/cache" 1.0 and the rewriting of the caching to the version 2.1. Reason for this is, that MM in version 2.3 requires doctrine/cache in version 2.1 and only in 2.1.
What do you think, is this okay for you or do you have any concerns?