Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abstractField): clearEncodingFunctions() #115

Merged
merged 1 commit into from Jul 24, 2017

Conversation

gbossert
Copy link
Member

The clearEncodingFunctions() doesn't work properly. It prevented multiple consecutive calls to encodingFunctions setter.

…the encoding functions preventing multiple consecutive calls to encodingFunctions setter
@gbossert gbossert added the bug label Jul 20, 2017
@gbossert gbossert requested review from Sygus and otetard July 20, 2017 08:22
@codecov-io
Copy link

codecov-io commented Jul 20, 2017

Codecov Report

Merging #115 into next will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #115      +/-   ##
==========================================
- Coverage   68.57%   68.53%   -0.05%     
==========================================
  Files         157      157              
  Lines        9483     9483              
==========================================
- Hits         6503     6499       -4     
- Misses       2980     2984       +4
Impacted Files Coverage Δ
...unctions/EncodingFunctions/TypeEncodingFunction.py 85.45% <ø> (ø) ⬆️
...etzob/src/netzob/Model/Vocabulary/AbstractField.py 75.1% <100%> (ø) ⬆️
...Model/Grammar/Transitions/OpenChannelTransition.py 79.31% <0%> (-13.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9217ed5...dee27d2. Read the comment docs.

@gbossert gbossert merged commit 5006b8d into netzob:next Jul 24, 2017
@gbossert gbossert deleted the fix/encoding_functions branch July 24, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants