Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BP] moved asserts to own class + add greater/lower_or_equals #279 #279

Closed
4 tasks done
Tracked by #304
netzulo opened this issue May 13, 2019 · 0 comments · May be fixed by #304
Closed
4 tasks done
Tracked by #304

[BP] moved asserts to own class + add greater/lower_or_equals #279 #279

netzulo opened this issue May 13, 2019 · 0 comments · May be fixed by #304
Assignees
@netzulo
Labels
Awaiting-PR Work In Progress at some pull request Best Practice Not functionality problem, but refactor need it Testcase

Comments

@netzulo
Copy link
Owner

netzulo commented May 13, 2019 •
edited
Loading

Obtained behaviour

Don't have _greater_or_equals + _lower_or_equals methods

Expected behaviour

  • Move Asserts method to own class without config or test class dependency
  • Have _greater_or_equals + _lower_or_equals methods

SPEC

  • refactor TestInfoBase.assert_lower
  • refactor TestInfoBase.assert_greater
  • add TestInfoBase.assert_lower_or_equals
  • add TestInfoBase.assert_greater_or_equals

Notes

Should exist tests to ensure this asserts
@netzulo netzulo self-assigned this May 13, 2019
@netzulo netzulo added Best Practice Not functionality problem, but refactor need it Testcase labels May 13, 2019
@netzulo netzulo linked a pull request Feb 9, 2020 that will close this issue
WIP, refactoring all library #304
Open
7 tasks
@netzulo netzulo added the Awaiting-PR Work In Progress at some pull request label Feb 9, 2020
netzulo added a commit that referenced this issue Feb 26, 2020
@netzulo
[qacode] fix for issue #279
1985f02
@netzulo netzulo mentioned this issue Mar 15, 2020
Open
7 tasks
netzulo added a commit that referenced this issue Apr 6, 2020
@netzulo
[qacode] fix for issue #279, for master branch
9a67656
@netzulo netzulo mentioned this issue Apr 6, 2020
Merged
1 task
netzulo added a commit that referenced this issue Apr 6, 2020
@netzulo
[qacode] fix for issue #279, for master branch (#311)
52a1213 
* [qacode] fix for issue #279, for master branch

* [qacode] fixes for flake
@netzulo netzulo closed this as completed Apr 6, 2020
@netzulo netzulo changed the title [BP] asserts _lower + _greater, add _greater_or_equals + _lower_or_equals [BP] moved asserts to own class + add greater/lower_or_equals #279 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netzulo netzulo

Labels
Awaiting-PR Work In Progress at some pull request Best Practice Not functionality problem, but refactor need it Testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP, refactoring all library netzulo/qacode
1 participant
@netzulo