Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Awaiter of ReactiveProperty is an unintended breaking changed #419

Closed
TORISOUP opened this issue Jun 24, 2019 · 2 comments
Closed

Awaiter of ReactiveProperty is an unintended breaking changed #419

TORISOUP opened this issue Jun 24, 2019 · 2 comments

Comments

@TORISOUP
Copy link

In UniRx 7.0.0, Awaiter of ReactiveProperty is changed from 6.2.2.

  1. It is not skip latest value.
  2. Observable is leaking.

var subscription = source.Subscribe(x => tcs.TrySetResult(x), ex => tcs.TrySetException(ex), () => tcs.TrySetCanceled());

I think that the previous behavior is equal to this.

var subscription = source.SkipLatestValueOnSubscribe().Take(1).Subscribe(x => tcs.TrySetResult(x), ex => tcs.TrySetException(ex), () => tcs.TrySetCanceled());
@neuecc
Copy link
Owner

neuecc commented Jun 28, 2019

Thanks, I'll fix to the same behavior and keep performance.

@neuecc
Copy link
Owner

neuecc commented Jul 1, 2019

I've released 7.1.0, it includes this fix.

@neuecc neuecc closed this as completed Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants