Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Improve UniRx.Async Cancellation and more features #337

Merged
merged 42 commits into from Aug 19, 2018
Merged

Conversation

neuecc
Copy link
Owner

@neuecc neuecc commented Aug 7, 2018

It has some breaking changes...

Rest of work

  • AsyncTriggers -> return UniTask or UniTask<(bool, T>) ???
  • SuppressCancellationThrow() -> T -> (bool, T)
  • ThrowIfOperationCanceled() -> (bool, T) -> T
  • AsyncTriggers.ConfigureCancellation(outer CancellationToken)
  • ReactiveProperty.ConfigureCancellation(outer CancellationToken)
  • ReusablePromise itself does not support SetCancellationToken in default.
  • UniTask.GetResult -> public.
  • PlayerLoopPromiseBase...

@neuecc
Copy link
Owner Author

neuecc commented Aug 13, 2018

(note) building tracking window for avoid task leak.

image

Next release(ver 6.2.0) will be a big improvement.

@neuecc
Copy link
Owner Author

neuecc commented Aug 14, 2018

TODO:remove IAwaiter.SetCancellationToken

//

.SuppressCancellationThrow() => (bool isCanceled, T value)
await ReactiveProperty.ConfigureAwait(cancellation); // (can suppress...)
AsyncTrigger(cancellation)

//

UniTask.Void
UniTask.Lazy

//

check defaultmaxnumberofarrayperbuckets

UniTaskSchedule.Unobserved - raise only mainthread

@neuecc
Copy link
Owner Author

neuecc commented Aug 19, 2018

runtime almost completed.
impl tracking window is not yet.

@neuecc neuecc changed the title [WIP]Improve UniRx.Async Cancellation Improve UniRx.Async Cancellation and more features Aug 19, 2018
@neuecc neuecc merged commit 2b42026 into master Aug 19, 2018
@neuecc neuecc deleted the improve-cancellation branch August 19, 2018 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant