This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Fix inner observer does not dispose parent on error #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faidra
changed the title
SeungHuLee
added a commit
to SeungHuLee/UniRx
that referenced
this pull request
Jan 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #350 .
Merging operators (Merge, Switch, and SelectMany) doesn't dispose parent subscription when inner subscription calls OnError, and this causes some odd behaviours.
InvalidOperationException: Disposable is already setin some conditionsThis change let they behave same as other operators.
(for example https://github.com/neuecc/UniRx/blob/master/Assets/Plugins/UniRx/Scripts/Operators/Zip.cs#L135-L141 )