Fix broken pretrained embeddings option (#400)

neulab · May 15, 2018 · 3704b20 · 3704b20
1 parent 8f807bb
commit 3704b20
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/test/test_run.py b/test/test_run.py
@@ -37,7 +37,6 @@ def test_multi_task_speech(self):
   def test_preproc(self):
     run.main(["test/config/preproc.yaml"])
 
-  @unittest.expectedFailure # TODO: these tests need to be fixed
   def test_pretrained_emb(self):
     run.main(["test/config/pretrained_embeddings.yaml"])
 

diff --git a/xnmt/embedder.py b/xnmt/embedder.py
@@ -317,7 +317,7 @@ def embed_sent(self, sent):
       return ExpressionSequence(expr_list=embeddings, mask=sent.mask)
 
 
-class PretrainedSimpleWordEmbedder(SimpleWordEmbedder):
+class PretrainedSimpleWordEmbedder(SimpleWordEmbedder, Serializable):
   """
   Simple word embeddings via lookup. Initial pretrained embeddings must be supplied in FastText text format.
   
@@ -335,6 +335,7 @@ class PretrainedSimpleWordEmbedder(SimpleWordEmbedder):
 
   yaml_tag = '!PretrainedSimpleWordEmbedder'
 
+  @register_xnmt_handler
   @serializable_init
   def __init__(self,
                filename,