[DO NOT MERGE] per-token dynamic observer #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satrat
reviewed
Apr 22, 2024
| @Observer.register("per_token", alias="per_token_dynamic") | ||
| class PerTokenObserver(Observer): | ||
| """ | ||
| Values targted for a dyanmic observer do not require calibration, |
| __all__ = ["PerTokenObserver"] | ||
|
|
||
|
|
||
| @Observer.register("per_token", alias="per_token_dynamic") |
There was a problem hiding this comment.
Are per token observers always dynamic?
Satrat
reviewed
Apr 22, 2024
bfineran
changed the title
|
@horheynm let's redo this PR as a quant arg |
bfineran
commented
Apr 25, 2024
| :return: tuple of scale and zero point derived from the observed tensor | ||
| """ | ||
| # reduce every dimension except token dimension | ||
| reduce_dims = [idx for idx in range(observed.dim()) if idx != self.axis] |
There was a problem hiding this comment.
should not reduce along batch as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for per-token dynamic observers. These observer find a scale and zero point for each group of values against a given token dimension.
TODO:
Unit testing