Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize disabling batch size across engine interfaces #1169

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Aug 4, 2023

This PR proposes changes to allow for the disabling of batch size checks, using batch size during random input generation, and disabling the engine's default batch size override behavior so the user doesn't need to define NM_BATCH_SIZE_OVERRIDE themselves

If a batch size of None or less than 1 is provided, a warning is logged and NM_DISABLE_BATCH_OVERRIDE is set. This provides a mechanism to disable the batch size override throughout the engine.


Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM - can you add a PR description with motivation + test scope?

@mgoin
Copy link
Member Author

mgoin commented Aug 7, 2023

@bfineran thanks and sorry this isn't complete, I meant to save it as a draft PR. Code is functional for my original needs but I have a new test suite I'd like to setup

@mgoin mgoin marked this pull request as draft August 7, 2023 18:40
@mgoin mgoin requested review from a team, dbogunowicz, rgreenberg1 and robertgshaw2-neuralmagic and removed request for a team August 14, 2023 21:27
@mgoin mgoin marked this pull request as ready for review August 14, 2023 21:27
@mgoin mgoin merged commit a70fee1 into main Aug 28, 2023
7 checks passed
@mgoin mgoin deleted the disable-batch-override branch August 28, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants