Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address py38/39 incompatibilities #261

Merged
merged 4 commits into from
May 28, 2024
Merged

Address py38/39 incompatibilities #261

merged 4 commits into from
May 28, 2024

Conversation

dbarbuzzi
Copy link

@dbarbuzzi dbarbuzzi commented May 22, 2024

SUMMARY

Handle a few different Python 3.8/3.9 compatibility issues:

  • Fix the Python 3.8 compatibility in one of our benchmarking scripts.
  • Fix skip for test_local_workers_clean_shutdown (previous skip attempt misused pytest.mark.skipif)
  • Skip test_merge_async_iterators (uses Python builtin anext which was added in 3.10)

@dbarbuzzi dbarbuzzi self-assigned this May 22, 2024
@dbarbuzzi dbarbuzzi changed the title Make benchmark script py38-compatible Address py38/39 incompatibilities May 23, 2024
@dbarbuzzi
Copy link
Author

The remote-push recently finished for this PR and py38 had two failures:

  1. One of the intermittent marlin failures
    • tests/models/test_marlin.py::test_models[5-32-half-model_pair0]
  2. The clean shutdown test failure
    • tests/engine/test_multiproc_workers.py::test_local_workers_clean_shutdown

@dbarbuzzi dbarbuzzi merged commit e168417 into main May 28, 2024
12 checks passed
@dbarbuzzi dbarbuzzi deleted the fix-benchmark-compat branch May 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants