Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quantization rounding #263

Closed
wants to merge 1 commit into from
Closed

Fix quantization rounding #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions csrc/quantization/compressed_tensors/int8_quant_kernels.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,25 @@
#include <ATen/cuda/CUDAContext.h>
#include <torch/extension.h>
#include <cmath>

#include "../../dispatch_utils.h"

static inline __device__ int8_t float_to_int8_rn(float x) {
static constexpr float dt_min =
#ifdef USE_ROCM
static const float i8_min =
static_cast<float>(std::numeric_limits<int8_t>::min());
static constexpr float dt_max =
static const float i8_max =
static_cast<float>(std::numeric_limits<int8_t>::max());
// round
float dst = round(x);
float dst = std::nearbyint(x);
// saturate
dst = std::clamp(dst, dt_min, dt_max);
dst = std::clamp(dst, i8_min, i8_max);
return static_cast<int8_t>(dst);
#else
uint32_t dst;
asm volatile("cvt.rni.sat.s8.f32 %0, %1;" : "=r"(dst) : "f"(x));
return reinterpret_cast<const int8_t&>(dst);
#endif
}

namespace vllm {
Expand Down