Testing fixes - notebooks, registry, model architectures #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bfineran
commented
Jan 25, 2021
•
bfineran
commented
- detection notebook constructor fix
- update registry to use latest sparsezoo api routes
- correct sparseml model architectures to match sparsezoo
- tf notebook recipe download fix
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kevinaer
suggested changes
Jan 25, 2021
bfineran
commented
Jan 26, 2021
kevinaer
previously approved these changes
Jan 26, 2021
markurtz
previously approved these changes
Jan 26, 2021
natuan
suggested changes
Jan 26, 2021
| @@ -2,6 +2,6 @@ | |||
| Generic code used as utilities and helpers for Keras | |||
| """ | |||
|
|
|||
| from .callbacks import * | |||
There was a problem hiding this comment.
The callback module imports logging so this will fail
There was a problem hiding this comment.
Importing out of order will be affected by isort. To avoid being dependent on the init file order, we can use absolute imports when referencing code from the same submodule. I've made this change in callbacks.py and verified the import passes.
natuan
approved these changes
Jan 26, 2021
markurtz
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.