Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress analytics errors and messages #318

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

markurtz
Copy link
Member

@markurtz markurtz commented May 25, 2023

This PR will suppress the following error message from google analytics

ERROR - 429 Client Error: Too Many Requests for url: http://ipinfo.io/96.89.198.177/json

Equivalent of #291

rahul-tuli
rahul-tuli previously approved these changes May 25, 2023
src/sparsezoo/analytics.py Outdated Show resolved Hide resolved
@rahul-tuli rahul-tuli requested review from mgoin and dhuangnm May 25, 2023 20:41
@rahul-tuli rahul-tuli added bug Something isn't working 1.5 release labels May 25, 2023
@markurtz markurtz merged commit 960cae2 into main May 26, 2023
4 checks passed
@markurtz markurtz deleted the suppress-analytics-errors branch May 26, 2023 04:51
rahul-tuli added a commit that referenced this pull request May 31, 2023
markurtz pushed a commit that referenced this pull request May 31, 2023
* Revert "Suppress analytics errors and messages (#318)"

This reverts commit 960cae2.

* Catch HttpError over exception

* Catch HttpError over exception when checking country
rahul-tuli added a commit that referenced this pull request May 31, 2023
* Revert "Suppress analytics errors and messages (#318)"

This reverts commit 960cae2.

* Catch HttpError over exception

* Catch HttpError over exception when checking country

(cherry picked from commit 9b5a0bd)
KSGulin pushed a commit that referenced this pull request Jun 1, 2023
* Revert "Suppress analytics errors and messages (#318)"

This reverts commit 960cae2.

* Catch HttpError over exception

* Catch HttpError over exception when checking country

(cherry picked from commit 9b5a0bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.5 release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants