Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing multiple name for registering a value in RegistryMixin #385

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Allow passing multiple name for registering a value in RegistryMixin #385

merged 1 commit into from
Nov 13, 2023

Conversation

dbogunowicz
Copy link
Contributor

Feature Description

Allows passing a List[str] to the name argument:

# register with multiple aliases
@Dataset.register(name=["cifar-10-dataset", "cifar-100-dataset"])
class Cifar(Dataset):
    pass

@dbogunowicz dbogunowicz mentioned this pull request Nov 10, 2023
Merged
@bfineran bfineran merged commit 1c6ee99 into main Nov 13, 2023
4 checks passed
@bfineran bfineran deleted the feature/damian/add_aliases_registry branch November 13, 2023 15:37
bfineran pushed a commit that referenced this pull request Nov 16, 2023
@dbogunowicz @bfineran
Allow passing multiple name for registering a value in RegistryMixin (#…
30fbeea 
…385)
bfineran pushed a commit that referenced this pull request Nov 16, 2023
@dbogunowicz @bfineran
Allow passing multiple name for registering a value in RegistryMixin (#…
178cbf5 
…385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@Satrat Satrat Awaiting requested review from Satrat

@dsikka dsikka Awaiting requested review from dsikka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbogunowicz @bfineran