Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix promise not awaited when inserting mri names #337

Merged
merged 3 commits into from Apr 19, 2022
Merged

fix promise not awaited when inserting mri names #337

merged 3 commits into from Apr 19, 2022

Conversation

ntraut
Copy link
Member

@ntraut ntraut commented Apr 18, 2022

I fixed some await problems when inserting a project to avoid concurrency problem. Hopefully this will fix the bug of some MRI annotations disappearing when inserting a project. I wasn't able to reproduce the bug but I'm still confident that this pr will fix it...


  • These changes fix #__ (github issue number if applicable).
  • npm run mocha-test ran with full success.
  • [] npm run mocha-test ran resulted in failure in _____
  • I implemented tests for the changes I made OR
  • These changes do not require tests because the bug is too difficult to reproduce in a test environment
  • All BrainBox tools behave as expected:
    • KEYS
      • right and left arrow keys
        • jump to next or previous slice within one brain, respectively
        • update the slider accordingly
        • update the slice number accordingly (upper left corner of the viewer window)
      • down and up arrow keys
        • jump to the next or previous brain within one project, respectively
        • update the selected subject in the annotation table
    • TOOL BUTTONS
      • minus
        • jumps to the previous slice within one brain
        • updates the slider accordingly
        • updates the slice number accordingly (upper left corner of the viewer window)
      • plus
        • jumps to the next slice within one brain
        • updates the slider accordingly
        • updates the slice number accordingly (upper left corner of the viewer window)
      • slider
        • updates slice view and slice number on the fly
      • sag / cor / axi buttons
        • switch view between the three orthogonal planes
      • show tool
        • when you click and drag in your browser window, this tool displays a cirlce at the position of your mouse click & drag as well as the user name in all browser windows connected to the same brain
      • the numbers at the bottom of the tool panel
        • change pencil size and eraser size accordingly
      • pencil tool
        • draws a line in the colour displayed in the color field
        • in combination with bucket tool filles a complete area with the chosen colour (be sure to have closed the contour line ;) Otherwise, the undo button will be your friend ;)
        • updates length and volume information (of what has been segmented) in the upper left corner of the viewer
      • erase tool
        • erases upon click drag from the annotation
        • in combination with the bucket tool erases the complete area of the color where you click
      • fill bucket tool
        • in combination with pencil tool
          • fills a complete area with the colour displayed in the colour field
        • in combination with erase tool
          • erases the complete area that is filled by the colour of where you click
      • colour field
        • displays the currently chosen colour to draw and fill
        • on click opens the set of colours available within the chosen label set where a new colour can be selected upon click
      • ruler tool
        • measures the distance between start and end of your defined path
          • points of mouse click appear and stay visible until you hit return key (this functionality is currently broken!) (you can click as many points as you wish to define the path you are interested in)
          • on return key, BrainBox will print the distance into the chat field (the ruler tool seems to be currently broken!!!)
      • adjust tool
        • slide opacity of overlaid annotation from 0 to 100%
        • increase or decrease brightness of the underlying MRI data
        • increase or decrease the contrast of the underlying MRI data
      • eyedropper tool
        • updates the colour field in the tool panel
        • displays/updates the region name in the upper left corner of the viewer
      • undo tool
        • undoes the user's actions in reverse chronological order and currently has the bug that it even undoes actions in slices you are currently not seeing! and there is currently no redo...
      • save button
        • saves the annotation of the data set into the data base
        • displays a message that user needs to login in case they are not
        • display a message Atlas saved Wed Oct 18 2017 12:49:12 GMT+0200 (CEST)

@ntraut
Copy link
Member Author

ntraut commented Apr 18, 2022

for codeql alerts, as usual they are not really new, codeql closed issues to re-create the same.
one is because we don't limit the domain of the mri url we download and the other is because we allow to bypass the certificate downloading an mri.

@katjaq
Copy link
Member

katjaq commented Apr 18, 2022

wuhuuuu! that's fantastic !!! So amazing!! Thank you so much @ntraut 🚀 🥳 ⭐

Copy link
Member

@katjaq katjaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @ntraut ! fantastic 🚀
I just had one little question regarding the function format in one case where you pass from arrow function to old function function format (see mattermost channel). otherwise ready to merge! 🚀 ⭐ Thank you so much!

@katjaq
Copy link
Member

katjaq commented Apr 19, 2022

ah, got your answer. Ok, thank you!
merging 🚀

@katjaq katjaq merged commit 3d80737 into master Apr 19, 2022
@ntraut ntraut deleted the insertdb branch August 4, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants