Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss][question] Size of $\epsilon$ term? #22

Closed
sneakers-the-rat opened this issue Feb 20, 2024 · 3 comments
Closed

[joss][question] Size of $\epsilon$ term? #22

sneakers-the-rat opened this issue Feb 20, 2024 · 3 comments

Comments

@sneakers-the-rat
Copy link

Part of: openjournals/joss-reviews#6336

The text reads

where $\epsilon$ is a small number used to prevent a division by 0 at the exact position of control points.

I see the $\epsilon$ term is set as 0.001 here:

const w = 1 / (d + 0.001);

Is that always a trivially small value, or is there some scale (that's reasonably likely in real data) where that might be a problem? I guess i am not quite clear on the units of the space to know. it seems like it's in voxel index space?

just posing as a question, y'all are the experts on brains of all sizes, and whether there might be some tiny hydra neuron edge case to worry about :)

@katjaq
Copy link
Member

katjaq commented Mar 19, 2024

Thank you for pointing this out.

It is indeed in voxel space, and with current MRI data, we would not expect this to become a problem. It does change the exact space at which a control point faints out, but in practice, the amount of voxels in an MRI even if it were smaller or bigger, is usually about 300. We also tested with high resolution data of small brains (for example a mouse: dim: 420 x 548 x 282, pixdim: 0.03 x 0.03 x 0.03) and also with a big dolphin brain (dim: 461 x 424 x 304, pixdim: 0.30 x 0.30 x 0.30) and the behaviour of the tool doesn't perceivably change.

But we could change it in future if we realise that it becomes a problem, so that a user could select a value.

@sneakers-the-rat
Copy link
Author

Question answered :) feel free to close or document, up 2 u

@katjaq
Copy link
Member

katjaq commented Apr 9, 2024

documented! In commit a061d22 Thank you again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants