[joss][chore] Remove unused and old code :) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katjaq
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks for spotting this @sneakers-the-rat and making our code clean :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: openjournals/joss-reviews#6336
quick chore, saw there was an unused function marked
OLDand a commented out function, so here's taking those out :)There is still a duplicated definition of
interpolationinthresholdmann-worker.jsandthresholdmann.js, but since this is vanilla JS where relying on global definition can be sorta sketch that's fine.