Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss][ui] numeric input #38

Closed
anibalsolon opened this issue Apr 19, 2024 · 1 comment
Closed

[joss][ui] numeric input #38

anibalsolon opened this issue Apr 19, 2024 · 1 comment

Comments

@anibalsolon
Copy link

Part of: openjournals/joss-reviews#6336

Currently, the threshold inputs are of type text. Given you are providing min and max, I assume it will always be a number. I'd suggest to change the field type to "number", so 1) the range is applied, and 2) no other values are provided (e.g. characters).

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number

image

@katjaq
Copy link
Member

katjaq commented Apr 27, 2024

Thank you for the suggestion. We implemented this change of input type from text to number in commit #ffbda69

@katjaq katjaq closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants