Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss][sec] possible injection and data leakage #39

Closed
anibalsolon opened this issue Apr 19, 2024 · 2 comments
Closed

[joss][sec] possible injection and data leakage #39

anibalsolon opened this issue Apr 19, 2024 · 2 comments

Comments

@anibalsolon
Copy link

Part of: openjournals/joss-reviews#6336

Loading a malicious JSON file can execute code and leak MRI data (or worse). A simple validation for numeric values during loading can prevent such scenario.

{"points":[[100,164,"0\"><script>window.alert('hey jude')</script><br style=\"display: none;\" data-close=\""]],"values":[10]}
@katjaq
Copy link
Member

katjaq commented Apr 27, 2024

Thank you for the note. We hadn't thought about this as usually the user themselves is the producer of the json file they'll later load. We'll integrate a sanitiser.

@katjaq
Copy link
Member

katjaq commented Apr 27, 2024

A check for numbers only has been implemented in # 6bdaf8c. Thank you @r03ert0 .

@katjaq katjaq closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants