Implement missing values discrete #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- discrete values component now has an extra UI element (red button) for each unique value that can label this value as "missing" - so far it doesn't do anything beyond being visible
- discrete value component can now emit an event when the "missing value" button is clicked to ask that the corresponding value be labeled as missing - the event is forwarded up to the annotation page - on the annotation page, a new method addMissingValue handles the event and saves the information to the global store
- only display unique values to be annotated that are not missing values - designating a value as missing now removes it from the list of values to be annotated and will
- annotation status will be true only when all unique values are mapped to a value that is not null and - if any non-mapped values are labeled as missing.
A number of things have changed in order to have a reactive annotation state check that can handle these cases: - an unannotated value has been declared missing - a unique value has been annotated Changes: - the valueMapper initialization has to happen during the "created" lifecycle stage so that we can use the valueMapping property in a computed prop - the button status is now computed property - this change allows us to scrap the previous watcher hack for the relevantColumn Property - in order to merge new annotations with the valueMapper property while not breaking reactivity, we have to do a deep merging of the objects. This is now done inside the updateMapping method
- discrete values component now has an extra UI element (red button) for each unique value that can label this value as "missing" - so far it doesn't do anything beyond being visible
- discrete value component can now emit an event when the "missing value" button is clicked to ask that the corresponding value be labeled as missing - the event is forwarded up to the annotation page - on the annotation page, a new method addMissingValue handles the event and saves the information to the global store
- only display unique values to be annotated that are not missing values - designating a value as missing now removes it from the list of values to be annotated and will
- annotation status will be true only when all unique values are mapped to a value that is not null and - if any non-mapped values are labeled as missing.
A number of things have changed in order to have a reactive annotation state check that can handle these cases: - an unannotated value has been declared missing - a unique value has been annotated Changes: - the valueMapper initialization has to happen during the "created" lifecycle stage so that we can use the valueMapping property in a computed prop - the button status is now computed property - this change allows us to scrap the previous watcher hack for the relevantColumn Property - in order to merge new annotations with the valueMapper property while not breaking reactivity, we have to do a deep merging of the objects. This is now done inside the updateMapping method
- discrete values component now has an extra UI element (red button) for each unique value that can label this value as "missing" - so far it doesn't do anything beyond being visible
- only display unique values to be annotated that are not missing values - designating a value as missing now removes it from the list of values to be annotated and will
A number of things have changed in order to have a reactive annotation state check that can handle these cases: - an unannotated value has been declared missing - a unique value has been annotated Changes: - the valueMapper initialization has to happen during the "created" lifecycle stage so that we can use the valueMapping property in a computed prop - the button status is now computed property - this change allows us to scrap the previous watcher hack for the relevantColumn Property - in order to merge new annotations with the valueMapper property while not breaking reactivity, we have to do a deep merging of the objects. This is now done inside the updateMapping method
…e' into implement-missing-values-discrete
|
I did a bit of a funny with my rebasing (picked master instead of the previous feature branch this was based off of). So for now, ignore the commit history of this branch. I will probably do another rebase to clean this up before we merge it. |
jarmoza
reviewed
May 9, 2022
|
You're clear to merge once (and if) you're addressing the |
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the interface and logic to declare missing values in the discrete-values component (atm used for the sex category).
Criteria from the issue were:
Accept when:
when that happens, the mapping of the value should be empty and the annotation status should be consider incompleteThe main addition here was making the state check for the "save annotation" button a computed property and turn all of its dependencies (e.g.
this.valueMapping) reactive.Resolves #120