Fixes for unique explanation component ID and client-only tags #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for two small fixes.
The first is to supply the explanation component on annotation tabs with a unique ID so has consistent behavior - each explanation component on each tab acts like it is a separate object with its own expansion status.
The second is to replace the old
no-ssrtag that is currently being used to overcome the duplicate annotation tab bug that @surchs discovered. The suggestedclient-onlytag has replaced it. There is no discernible difference other than the deprecatedno-ssrtag warning disappearing from the debug console.Resolves #116
Resolves #109