Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index page refactor #302

Merged
merged 9 commits into from
Jan 6, 2023
Merged

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Jan 6, 2023

Closes #298

Co-authored-by: Jonathan Armoza jarmoza@gmail.com

surchs and others added 8 commits January 5, 2023 17:41
@surchs surchs requested a review from jarmoza January 6, 2023 18:13
Copy link
Contributor

@jarmoza jarmoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few extras to remove for the refactor and good to go.

pages/index.vue Outdated Show resolved Hide resolved
pages/index.vue Outdated Show resolved Hide resolved
pages/index.vue Outdated Show resolved Hide resolved
remove deprecated dependencies
@surchs surchs requested a review from jarmoza January 6, 2023 18:37
@surchs
Copy link
Contributor Author

surchs commented Jan 6, 2023

Thanks for the comments @jarmoza. I think I got them all. Let me know if you see something else, I'll go do your PRs now!

Copy link
Contributor

@jarmoza jarmoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @surchs!

@surchs surchs merged commit 45d4491 into dev_components_talk_to_store_directly Jan 6, 2023
@surchs surchs deleted the surchs/issue298 branch January 6, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants