Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of old download components and related functionality #409

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Removal of old download components and related functionality #409

merged 2 commits into from
Apr 19, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Apr 19, 2023

This PR closes #399 by doing the following:

  • The table used to show the former annotated data table has been removed
  • Associated methods used to build the JSON for output download have been removed
  • Some functionality left in but commented out as a guide for update to new annotated data dictionary download code and possible new preview textbox for the annotated data dictionary
  • Code cleanup + updated comments

@jarmoza jarmoza added download page maint:refactor Simplifying or restructuring existing code or documentation. labels Apr 19, 2023
@rmanaem rmanaem self-requested a review April 19, 2023 16:32
@jarmoza jarmoza linked an issue Apr 19, 2023 that may be closed by this pull request
Remove the table and associated methods #399
Closed
rmanaem
rmanaem approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏼‍🍳

@jarmoza jarmoza merged commit 187e7f0 into dev_components_talk_to_store_directly Apr 19, 2023
3 checks passed
@jarmoza jarmoza deleted the jarmoza-399 branch April 19, 2023 19:19
@jarmoza jarmoza mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
download page maint:refactor Simplifying or restructuring existing code or documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the table and associated methods
2 participants
@jarmoza @rmanaem