Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query tool unable to parse diagnosis and assessment tool options coming from a node API #223

Closed
rmanaem opened this issue Jul 22, 2024 · 0 comments
Assignees
Labels
bug:functional Functional defects resulting from feature changes. type:bug Defects in shipped code and fixes for those defects

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Jul 22, 2024

When we modified query tool to handle partial node failure/success it seems we forgot to take node API into account so part of the code looks for custom fields in the response object e.g., response.data.errors that are specific to the response coming from the federation API.
This results in the parsing of the options failing when the query tool points to a node API i.e., NB_IS_FEDERATION_API=false. So the requests go through and come back green but you will see no options in diagnosis and assessment tool dropdowns.

@rmanaem rmanaem self-assigned this Jul 22, 2024
@rmanaem rmanaem added bug:functional Functional defects resulting from feature changes. type:bug Defects in shipped code and fixes for those defects labels Jul 22, 2024
@rmanaem rmanaem closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:functional Functional defects resulting from feature changes. type:bug Defects in shipped code and fixes for those defects
Projects
Status: Review - Done
1 participant