added xor_nxor_supervised_alignment experiment #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSSF23
requested changes
Dec 12, 2020
There was a problem hiding this comment.
@ykobaya9 here is a list of what needs to be addressed in order:
- Remove empty cell in the notebook
- Markdown your title with "#" instead of "##" reserved for subtitles
- Unify names of tutorial and function file, and I recommend
xor_rxor_with_icp. Is itrxorornxor? - Add the updated name to a proper place in
tutorials.rst
|
Hi @PSSF23, thanks for the feedback! Just made the changes you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes issue #290
Type of change
This is my sprint 1 PR with a tutorial notebook on task alignment using a supervised iterative method, based on the ICP algorithm (https://ieeexplore.ieee.org/document/121791). The tutorial notebook is based on #389, since the effectiveness of both domain adaptation algorithms is validated using the same xor-rxor experiment.
What does this implement/fix?
The approach of aligning tasks is different from the CPD method, since this method uses supervision to find a suitable rigid affine registration that aligns the classes + the point distribution. The CPD method only aligns the point distribution without information about classes, which is sufficient for improving BTE (as shown by high BTE in xor-nxor experiment).
Additional information