Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RXOR and XNOR Experiments #30

Merged
merged 9 commits into from Nov 13, 2021
Merged

Conversation

nhahn7
Copy link
Contributor

@nhahn7 nhahn7 commented Nov 12, 2021

Close #31 Added two XOR streaming benchmark experiments to compare SDT/SDF performance against Mondrian Forest and Hoeffding Tree.

  • r_xor.py runs the RXOR experiment
  • xnor.py runs the XNOR experiment
  • xor_functions.py includes functions used by both experiments and the Jupyter Notebook
  • xor_experiments.ipynb plots data/results
  • results are stored in benchmarks/results

@netlify
Copy link

netlify bot commented Nov 12, 2021

✔️ Deploy Preview for sdtf ready!

🔨 Explore the source changes: ff11943

🔍 Inspect the deploy log: https://app.netlify.com/sites/sdtf/deploys/618f26b21f7c5600085a45a0

😎 Browse the preview: https://deploy-preview-30--sdtf.netlify.app/xor_experiments

@PSSF23 PSSF23 added the enhancement New feature or request label Nov 12, 2021
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good job! All you need to do is to black format your notebook. After merging I might do some minor changes on text.

Remember to pull my changes before committing!

@nhahn7
Copy link
Contributor Author

nhahn7 commented Nov 13, 2021

@PSSF23 I seem to be having some issues with black formatting using https://github.com/csurfer/blackcellmagic. Do you have a recommendation for what to use?

@PSSF23
Copy link
Member

PSSF23 commented Nov 13, 2021

@nhahn7 Don't use those anymore, black officially supports jupyter notebooks now. Just pip install black[jupyter].

@nhahn7
Copy link
Contributor Author

nhahn7 commented Nov 13, 2021

@PSSF23 that seems to have fixed it. Thanks

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@PSSF23 PSSF23 merged commit 31d68b7 into neurodata:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gaussian simulation experiments
2 participants