Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relevant notebooks #255

Merged
merged 10 commits into from
Apr 5, 2021
Merged

Fix relevant notebooks #255

merged 10 commits into from
Apr 5, 2021

Conversation

bvarjavand
Copy link
Contributor

  1. fix filepaths for uploading notebook
  2. with use_https=True we don't need an aws key for downloading notebook
  3. clean data uploading by adding to .gitignore

Copy link
Member

@tathey1 tathey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, i believe the reason tests fail are because you need to bump nilearn version to 0.7.0 in requirements.txt (this has been changed in the develop branch).

brainlit/algorithms/__init__.py Outdated Show resolved Hide resolved
brainlit/algorithms/trace_analysis/__init__.py Outdated Show resolved Hide resolved
brainlit/utils/session.py Outdated Show resolved Hide resolved
@bvarjavand
Copy link
Contributor Author

@alishakodibagkar I'm getting this error on NeuronTrace's test

=========================== short test summary info ============================
ERROR brainlit/utils/tests/test_Neuron_trace.py - cloudvolume.exceptions.InfoUnavailableError: No info file was found: file:///home/circleci/project/data/test_upload_segments/info
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

The full log is in the most recent circleCI build for this branch. Any advice?

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #255 (65c3be0) into tathey1-fixdocs (7cb5d84) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           tathey1-fixdocs     #255      +/-   ##
===================================================
+ Coverage            46.57%   46.65%   +0.07%     
===================================================
  Files                   42       43       +1     
  Lines                 3697     3702       +5     
===================================================
+ Hits                  1722     1727       +5     
  Misses                1975     1975              
Impacted Files Coverage Δ
brainlit/algorithms/generate_fragments/tube_seg.py 91.25% <ø> (ø)
brainlit/registration/visualization.py 9.37% <ø> (ø)
brainlit/algorithms/__init__.py 100.00% <100.00%> (ø)
brainlit/algorithms/generate_fragments/__init__.py 100.00% <100.00%> (ø)
brainlit/algorithms/trace_analysis/__init__.py 100.00% <100.00%> (ø)
brainlit/utils/Neuron_trace.py 91.31% <100.00%> (+0.04%) ⬆️
brainlit/utils/session.py 97.22% <100.00%> (+0.03%) ⬆️

@bvarjavand bvarjavand requested a review from tathey1 April 5, 2021 17:31
Copy link
Member

@tathey1 tathey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes have been made

@tathey1 tathey1 merged commit 1b562bf into tathey1-fixdocs Apr 5, 2021
@tathey1 tathey1 deleted the bvarjavand-fixdocs branch April 5, 2021 20:04
@bvarjavand bvarjavand restored the bvarjavand-fixdocs branch April 6, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants