Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double SVD computation for selectSVD #208

Open
j1c opened this issue Jun 24, 2019 · 2 comments
Open

Prevent double SVD computation for selectSVD #208

j1c opened this issue Jun 24, 2019 · 2 comments
Labels
enhancement New feature or request important

Comments

@j1c
Copy link
Collaborator

j1c commented Jun 24, 2019

Expected Behavior

SVD should be only computed once. When select_dimension is called, we already do an SVD, so no need to do it the second time once the embedding dimension is called.

Actual Behavior

SVD is done twice when using select_dimension
@bdpedigo bdpedigo added this to the GraSPy 0.0.4 milestone Jul 12, 2019
@bdpedigo bdpedigo removed this from the GraSPy 0.0.4 milestone Feb 13, 2020
@bdpedigo bdpedigo added the enhancement New feature or request label Apr 17, 2020
@dfrancisco1998
Copy link
Contributor

I am interested!

@bdpedigo bdpedigo mentioned this issue Mar 24, 2021
Closed
@rajpratyush
Copy link

@j1c could you explain me this ? especially the embedding dimension section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@j1c @bdpedigo @dfrancisco1998 @rajpratyush