Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discriminability summary rank report #200

Open
gkiar opened this issue Jun 14, 2021 · 3 comments
Open

discriminability summary rank report #200

gkiar opened this issue Jun 14, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@gkiar
Copy link

gkiar commented Jun 14, 2021

Is your feature request related to a problem? Please describe.
I want to know how different subjects are performing in my dataset. This can help with QC and improving discriminability by excluding subjects/sessions, esp. since one very bad subject is different than all slightly bad subjects, but both may result in similar scores.

Describe the solution you'd like
After the rank distribution is calculated here, we could have another function definition which prints a report. I imagine something like:

subject ranks
1 1, 2, 8
2 1, 1, 3
... ...

It would also be nice to print things like mean w/in subject rank, or the variance in w/in subject ranks, etc... the motivation still being that these could be helpful QC figures.

@gkiar gkiar added the enhancement New feature or request label Jun 14, 2021
@sampan501
Copy link
Member

@ebridge2 any thoughts?

@ebridge2
Copy link

Sounds great; though the print out (if I'm understanding right) should be a 3-column; sample id (1:n, in the order passed in), subject, then ranks.

Agree within vs between-individual discriminabilities could be great, and there are other awesome QC things as well that one can trivially do with this stuff; @gkiar if you are still in the overleaf for discriminability, check out section "Discriminability Decomposition" in the appendix (I want to say section G off top of my head?).

@gkiar
Copy link
Author

gkiar commented Jun 15, 2021

Hey @ebridge2 I'll go check that out, thanks for the pointer!

Re the table: the reason I suggested 2 columns is we really want something digestible and which can be skimmed easily, but of course you're right in that the ranks for sub-1_obs-1 may not be the same for sub_1-obs-2, etc..

Perhaps a way to meet in the middle is to have a table still indexed by subject ID, a second column which includes all sample IDs corresponding to that subject, and then the third showing the ranks for each pair of observations (which, ideally, would be in a consistent order so you could identify which comparisons were the poorer ones among all samples).

e.g.

subject ID sample IDs ranks
1 1, 2, 5 1, 2, 8
2 3, 4, 6 1, 1, 3
... ... ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants