Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type checking #357

Merged
merged 1 commit into from Mar 9, 2023
Merged

Fix type checking #357

merged 1 commit into from Mar 9, 2023

Conversation

j1c
Copy link
Member

@j1c j1c commented Mar 8, 2023

Reference issue

Type of change

Fixed a type check in perm blocks

What does this implement/fix?

np.integer encompasses all integer types including python int. Changes to check if its any type of int rather than just python int.

Additional information

@j1c j1c requested a review from sampan501 March 8, 2023 19:08
@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for hyppo ready!

Name Link
🔨 Latest commit d11afaa
🔍 Latest deploy log https://app.netlify.com/sites/hyppo/deploys/6408dd50282a8300087510c7
😎 Deploy Preview https://deploy-preview-357--hyppo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (f8d158b) 96.73% compared to head (d11afaa) 96.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #357      +/-   ##
==========================================
+ Coverage   96.73%   96.78%   +0.05%     
==========================================
  Files          84       84              
  Lines        3732     3732              
==========================================
+ Hits         3610     3612       +2     
+ Misses        122      120       -2     
Impacted Files Coverage Δ
hyppo/tools/common.py 95.06% <100.00%> (+0.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sampan501 sampan501 merged commit 0c2c33f into dev Mar 9, 2023
@sampan501 sampan501 deleted the permgroup_bug branch March 9, 2023 00:14
@sampan501 sampan501 restored the permgroup_bug branch March 9, 2023 00:15
sampan501 added a commit that referenced this pull request Mar 9, 2023
@sampan501 sampan501 added the bug Something isn't working label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants