Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in monotonicity #47

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Bring in monotonicity #47

merged 1 commit into from
Jul 5, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Jul 5, 2023

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Signed-off-by: Adam Li <adam2392@gmail.com>
@github-actions github-actions bot added the cython label Jul 5, 2023
@adam2392 adam2392 merged commit 6b57c58 into submodulev2 Jul 5, 2023
5 of 10 checks passed
@adam2392 adam2392 deleted the mono branch July 5, 2023 14:52
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here


ruff

ruff detected issues. Please run ruff --fix --show-source . locally, fix the remaining issues, and push the changes. Here you can see the detected issues. Note that the installed ruff version is ruff=0.0.277.


sklearn/ensemble/_forest.py:2293:1: W293 [*] Blank line contains whitespace
     |
2292 |         .. versionadded:: 0.22
2293 |     
     | ^^^^ W293
2294 |     max_bins : int, default=255
2295 |         The maximum number of bins to use for non-missing values.
     |
     = help: Remove whitespace from blank line

Found 1 error.
[*] 1 potentially fixable with the --fix option.

cython-lint

cython-lint detected issues. Please fix them locally and push the changes. Here you can see the detected issues. Note that the installed cython-lint version is cython-lint=0.15.0.


/home/runner/work/scikit-learn/scikit-learn/sklearn/tree/_splitter.pyx:303:1: W293 blank line contains whitespace
/home/runner/work/scikit-learn/scikit-learn/sklearn/tree/_tree.pyx:360:24: dict key n_constant_features repeated 2 times

Generated for commit: a472aa1. Link to the linter CI: here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant