Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Adding notebooks for might/comight cancer #172

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Nov 15, 2023

Follow-up to #152

Closes: #176

Changes proposed in this pull request:

  • Add figures demonstrating superiority of MultiviewDTC vs DTC via partial-AUC
  • Add figures demonstrating superiority of CoMight and MIGHT with MVRF vs RF using mutual info.
  • Fixes a bug related to the max_features sampling when there are three or more views

The bug basically meant that when we had more than 2 feature-sets, we have the following behavior:

with max_features = 0.3

n_features_per_view = [500, 500, 500]
feature_set_ends = [500, 1000, 1500]
max_feature_per_set_ = [150, 150, 300]

because max_feature_per_set_ = [500 * 0.3, 500 * 0.3, 1000 * 0.3], which was a basic programming error.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b81891e) 90.52% compared to head (2a52c40) 90.64%.

❗ Current head 2a52c40 differs from pull request most recent head b87a8e9. Consider uploading reports for the commit b87a8e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   90.52%   90.64%   +0.12%     
==========================================
  Files          48       48              
  Lines        4020     4072      +52     
==========================================
+ Hits         3639     3691      +52     
  Misses        381      381              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 2fa5a83 into neurodata:main Dec 1, 2023
24 checks passed
@adam2392 adam2392 deleted the comightfigs branch December 1, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue when using multi-view decision trees for 3-view+ datasets
1 participant