-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add basic MORF implementation and design #21
Conversation
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@jshinm I will probably merge this in once I get the CIs working, but you may be interested in reviewing just the files in The rest of the files are irrelevant unless you are interested in trying to improve the MORF trees. |
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Codecov ReportBase: 0.00% // Head: 83.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 0.00% 83.66% +83.66%
==========================================
Files 2 8 +6
Lines 101 557 +456
==========================================
+ Hits 0 466 +466
+ Misses 101 91 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
An issue seems that there is something up w/ Patch Oblique tree that fails on occasion:
This could be due to resolving ties, or something, but it seems that it occurs only on 1 of the samples. Moreover, taking a look at https://github.com/scikit-learn/scikit-learn/blob/7970d78cfc1f8e705a8f417f29bb47b08e1bf0aa/sklearn/utils/estimator_checks.py#L1040, it seems that the last samples are essentially the same as the rest, so this could be a numerical issue from breaking ties or something. Might be a deeper Cython issue where we need to figure out where some ties might occur. |
Towards #20
Need to also think about the design of the Cython API to allow future possibilities. Also porting over the oblique tree and related examples.
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting