ENH optimize & add treeple tutorial figures #260
Conversation
PSSF23
commented
Apr 19, 2024
•
PSSF23
commented
- Reorder by single view and multiview
- Optimize figure style to be consistent with paper using: 1d & 2d
- Add mutual information difference figure
- Select thumbnail for specific tutorials
- Output all statistics
- Add hellinger distance tutorial
- Add 2d plots for permuted 2-view data
- Change text color in the note box to blue
& DOC optimize text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 54 54
Lines 5105 5105
=======================================
Hits 4597 4597
Misses 508 508 ☔ View full report in Codecov by Sentry. |
| Treeple tutorial for calculating CMI | ||
| ==================================== | ||
| ===================== | ||
| 2-1b: Calculating CMI |
There was a problem hiding this comment.
I don't think most ppl will know the order of our figures. Can we remove the numbering in the title? We can still order the sphinx examples as how it shows up tho.
There was a problem hiding this comment.
This is not related to the figures, just to separate single view and multiview. If we can order them with other methods, that would be great.
There was a problem hiding this comment.
https://sphinx-gallery.github.io/stable/gen_modules/sphinx_gallery.sorting.html
We can prolly just rename the filenames and apply a sorting based on that if we want the titles to be more specific.
E.g. FileNameSortKey
| from scipy.stats import entropy | ||
|
|
||
| from sktree.datasets import make_trunk_classification | ||
| from sktree.ensemble import HonestForestClassifier | ||
| from sktree.stats import build_hyppo_oob_forest | ||
| from sktree.tree import MultiViewDecisionTreeClassifier | ||
|
|
||
| sns.set(color_codes=True, style="white", context="talk", font_scale=1.5) |
There was a problem hiding this comment.
Maybe add a comment above stating we are using some formatting to make the figure look as close to "TODO" insert citation to the paper.
There was a problem hiding this comment.
I don't feel that's necessary. It's just a figure style? Definitely agree on citing the paper somewhere when it's out.
