Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the pkg to treeple #261

Closed
wants to merge 3 commits into from
Closed

Renaming the pkg to treeple #261

wants to merge 3 commits into from

Conversation

SUKI-O
Copy link
Member

@SUKI-O SUKI-O commented Apr 23, 2024

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@SUKI-O SUKI-O requested a review from adam2392 April 23, 2024 02:54
@adam2392
Copy link
Collaborator

I tried this locally and there are a number of issues:

  1. All directories must contain a meson.build file. I'm unsure how you approached this renaming, but I would just literally rename the directory and then ctrl+f and ctrl+replace "scikit-tree/sktree" -> "treeple". Rn, treeple/meson.build does not exist anymore.
  2. https://stackoverflow.com/questions/4526910/rename-a-git-submodule specifies how to rename a git submodule. You just have to "rename" the file directory expected

Afterwards, I would expect an update to the changelog informing users how to transition their code.

An open question is do we want to encourage usage of the pattern: import treeple as tp vs from treeple import RandomForestClassifier?

@adam2392 adam2392 deleted the branch temp2 April 26, 2024 07:58
@adam2392 adam2392 closed this Apr 26, 2024
@adam2392
Copy link
Collaborator

Apologies! I messed up the main branch, and as a result this PR auto-closed. Do you mind resubmitting it to main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants