Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] MORF can now sample n-dimensional data with n-dimensional patches #63

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

adam2392
Copy link
Collaborator

Fixes #62

Changes proposed in this pull request:

  • n-dims patches and n-dims arrays

TODO:

  • add discontinuity parameters

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 94.26% and project coverage change: -0.10 ⚠️

Comparison is base (c6aeca7) 91.70% compared to head (2709530) 91.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   91.70%   91.60%   -0.10%     
==========================================
  Files           9       10       +1     
  Lines         808      882      +74     
==========================================
+ Hits          741      808      +67     
- Misses         67       74       +7     
Impacted Files Coverage Δ
sktree/tests/test_supervised_forest.py 99.30% <ø> (ø)
sktree/tree/_classes.py 86.69% <82.35%> (-2.09%) ⬇️
sktree/tree/tests/test_utils.py 98.71% <98.71%> (ø)
sktree/ensemble/_supervised_forest.py 100.00% <100.00%> (ø)
sktree/tree/tests/test_tree.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 marked this pull request as ready for review April 14, 2023 23:51
@adam2392 adam2392 merged commit b6d1adb into main Apr 14, 2023
21 of 22 checks passed
@adam2392 adam2392 deleted the morf branch April 14, 2023 23:52
SUKI-O pushed a commit to SUKI-O/scikit-tree that referenced this pull request Apr 18, 2023
…es (neurodata#63)

* Allow patches to be n-dimensional
* Allow discontinuity in the sampling of the first dimension
* Adding projection matrix sampling example

---------

Signed-off-by: Adam Li <adam2392@gmail.com>
SUKI-O pushed a commit to SUKI-O/scikit-tree that referenced this pull request Apr 29, 2023
…es (neurodata#63)

* Allow patches to be n-dimensional
* Allow discontinuity in the sampling of the first dimension
* Adding projection matrix sampling example

---------

Signed-off-by: Adam Li <adam2392@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow patch sampling to be discontiguous and parse out the dimensions of the patches
1 participant