Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add kernel decision tree - Gaussian, Gabor, etc. #70

Closed
wants to merge 17 commits into from
Closed

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Apr 26, 2023

Fixes #20

Changes proposed in this pull request:

  • implements a base class for kernel defined decision trees
  • Implements n-dim Gaussian Kernel
  • implement n-dim Wavelet Kernel
  • Implements 2D Gabor kernel

To build 1D filter bank of wavelets: https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.morlet.html#scipy.signal.morlet

To build 2D filter bank of Gabor kernel:
https://scikit-image.org/docs/stable/api/skimage.filters.html#gabor-kernel

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 17.64% and project coverage change: -3.26 ⚠️

Comparison is base (32162e4) 92.64% compared to head (33e9875) 89.39%.

❗ Current head 33e9875 differs from pull request most recent head ca00632. Consider uploading reports for the commit ca00632 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   92.64%   89.39%   -3.26%     
==========================================
  Files          12       10       -2     
  Lines        1142      924     -218     
==========================================
- Hits         1058      826     -232     
- Misses         84       98      +14     
Impacted Files Coverage Δ
sktree/tree/_classes.py 78.80% <17.64%> (-8.16%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of general MORF trees (Gabor, Fourier, Gaussian, and generic kernels)
1 participant