Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glossary #144

Merged
merged 5 commits into from
Apr 12, 2019
Merged

Add glossary #144

merged 5 commits into from
Apr 12, 2019

Conversation

TomDonoghue
Copy link
Member

Related to #138 - this is place for us to broadly work on and discuss a potential glossary.

So far I just added a sphinx style glossary file, and a really quick scan collecting some terms that could potentially go into it.

The idea is that we can somewhat crowdsource this glossary - so if you have a suggested term or definition - throw it here! In terms of scope, this glossary should be fairly light on the level of detail, offering just a quick definition, but link out to as many resources as we can find to help find and scaffold support for DSP and it's neuroscience applications.

@TomDonoghue
Copy link
Member Author

TomDonoghue commented Mar 2, 2019

Collection of Resources to link to:

General DSP:

Filtering:

1/f Properties:

@neurodsp-tools neurodsp-tools deleted a comment from codecov-io Apr 5, 2019
@TomDonoghue TomDonoghue changed the title WIP: Add glossary Add glossary Apr 5, 2019
@TomDonoghue TomDonoghue requested review from rdgao and voytek April 5, 2019 17:49
Copy link
Contributor

@voytek voytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this as-is, since I see it as a living document. I have links and other bits I can add, but I'll do so later, once I have time to collect all my thoughts and resources.

@neurodsp-tools neurodsp-tools deleted a comment from codecov-io Apr 5, 2019
@TomDonoghue
Copy link
Member Author

@rdgao : if you want to give this a once-over that I didn't write in anything totally ludicrous, then I'll merge it as a first draft (that we can edit / amend as we go).

doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
doc/glossary.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@rdgao rdgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise looks great

Copy link
Member Author

@TomDonoghue TomDonoghue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments @rdgao

I pushed updates based on these comments. Most things are straight-forward, and I fixed up the powerlaw / 1/f part a bit, if you want to eyeball that and see if it tracks better now.

@neurodsp-tools neurodsp-tools deleted a comment from codecov-io Apr 11, 2019
@neurodsp-tools neurodsp-tools deleted a comment from codecov-io Apr 11, 2019
@neurodsp-tools neurodsp-tools deleted a comment from codecov-io Apr 11, 2019
@neurodsp-tools neurodsp-tools deleted a comment from codecov-io Apr 11, 2019
@TomDonoghue TomDonoghue merged commit 3057ac9 into master Apr 12, 2019
@TomDonoghue TomDonoghue deleted the glossary branch April 12, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants